Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kotlin client issue in maven plugin tests #9690

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Fix kotlin client issue in maven plugin tests #9690

merged 3 commits into from
Jun 7, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jun 7, 2021 •
edited
Loading

  • Fix kotlin client issue in maven plugin tests:
[ERROR] /Users/williamcheng/Code/openapi-generator/modules/openapi-generator-maven-plugin/examples/target/generated-sources/kotlin/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt: (183, 81) Unresolved reference: lowercase
[ERROR] /Users/williamcheng/Code/openapi-generator/modules/openapi-generator-maven-plugin/examples/target/generated-sources/kotlin/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt: (198, 74) Unresolved reference: lowercase
[ERROR] Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:1.5.10:compile (compile) on project sample-project: Compilation failure: Compilation failure: 
[ERROR] /Users/williamcheng/Code/openapi-generator/modules/openapi-generator-maven-plugin/examples/target/generated-sources/kotlin/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt:[183,81] Unresolved reference: lowercase
[ERROR] /Users/williamcheng/Code/openapi-generator/modules/openapi-generator-maven-plugin/examples/target/generated-sources/kotlin/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt:[198,74] Unresolved reference: lowercase
  • Update doc

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 marked this pull request as ready for review June 7, 2021 04:44
@wing328 wing328 requested a review from jimschubert as a code owner June 7, 2021 04:44
@wing328 wing328 added this to the 5.2.0 milestone Jun 7, 2021
@wing328 wing328 merged commit c2cc7a0 into master Jun 7, 2021
@wing328 wing328 mentioned this pull request Jun 7, 2021
Merged
5 tasks
@wing328 wing328 deleted the mavenplugin-kotlin-fix branch June 8, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimschubert jimschubert Awaiting requested review from jimschubert

Assignees
No one assigned
Labels
Enhancement: CI/Test OpenAPI Generator Maven Plugin
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@wing328